Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Revision Label makes terraform plan think helm release has changes #577

Open
jay-docusign opened this issue Oct 25, 2023 · 1 comment

Comments

@jay-docusign
Copy link

jay-docusign commented Oct 25, 2023

Describe the Issue
Code adds a .Revision label to everything
https://github.com/virtual-kubelet/azure-aci/blob/master/charts/virtual-kubelet/templates/_helpers.tpl#L25

This results in helm template returning a manifest which has diffs in labels and checksum.

Steps To Reproduce
Example

"virtual-kubelet-test/deployment.apps/apps/v1/virtual-kubelet-release-test-virtual-kubelet-azure-aci"                                                 = {

                  ~ metadata   = {
                      ~ labels    = {
                          ~ revision     = "21" -> "22"
                            # (6 unchanged attributes hidden)
                        }
                        name      = "virtual-kubelet-release-test-virtual-kubelet-azure-aci"
                        # (1 unchanged attribute hidden)
                    }
                  ~ spec       = {
                      ~ template = {
                          ~ metadata = {
                              ~ annotations = {
                                  ~ "checksum/secret" = "7bffddf3d3196ab131293bf3d4a390e339a9df50dadaa64cf6dcc78961ef2142" -> "d1c5fdc3851dbea0e8b748f5dc3fd3fc936811e33592267ba709342714e99fd3"
                                }
                                # (1 unchanged attribute hidden)
                            }
                            # (1 unchanged attribute hidden)
                        }
                        # (2 unchanged attributes hidden)
                    }
                    # (2 unchanged attributes hidden)
                }

Expected behavior
helm template should not show any changes from existing release by default.
Ways to achieve:

  1. Remove Revision label completely
  2. Put Revision label behind a conditional
  3. Allow labels to be modifiable via Values

Virtual-kubelet version
1.6.0

Kubernetes version
1.24

Additional context

@phynot
Copy link

phynot commented May 7, 2024

@helayoty @smritidahal653 would you please review this issue and let us know if it can be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants