Implement File Storing Mechanism for toDot Method Output in VerkleTrie #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matkt
requested changes
Nov 16, 2023
src/main/java/org/hyperledger/besu/ethereum/trie/verkle/exporter/DotExporter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/hyperledger/besu/ethereum/trie/verkle/exporter/DotExporter.java
Outdated
Show resolved
Hide resolved
matkt
reviewed
Nov 16, 2023
|
|
||
| private static void handleFileWritingError(String errorMessage, Exception exception) { | ||
| LOG.error("Error writing DOT file: {}. Details: {}", errorMessage, exception.getMessage(), exception); | ||
| exception.printStackTrace(); |
There was a problem hiding this comment.
maybe better to throw the exception instead of doing a printstacktrace, like that the caller can now if the write failed or not
matkt
reviewed
Nov 16, 2023
| child.getLocation().orElse(Bytes.EMPTY)); | ||
|
|
||
| if (showRepeatingEdges || !result.contains(edgeString)) { | ||
| result += edgeString; |
There was a problem hiding this comment.
in general in java it's better to use StringBuilder instead of using +=, because it will create new string everytime and it's not efficient
matkt
requested changes
Nov 17, 2023
build.gradle
Outdated
| @@ -52,12 +52,15 @@ dependencies { | |||
| implementation 'io.tmio:tuweni-rlp' | |||
| implementation 'org.hyperledger.besu:ipa-multipoint' | |||
| implementation 'org.hyperledger.besu.internal:trie:23.1.3-SNAPSHOT' | |||
| implementation 'org.slf4j:slf4j-api:1.7.32' | |||
There was a problem hiding this comment.
version shoud be in the version.gradle file and the version are too old
https://mvnrepository.com/artifact/org.slf4j/slf4j-api/2.0.9
is logback really needed or just slf4J ?
There was a problem hiding this comment.
- I agree with your suggestion to manage the version in the 'version.gradle' file. I will ensure to update them accordingly.
- Additionally, regarding the inclusion of SLF4J and Logback in the build.gradle file, SLF4J is an abstraction that requires an underlying logging framework to function. This is why I included 'ch.qos.logback:logback-classic' in the dependencies. Without this implementation, Log.info/error, etc., won't work. For example, after removing the implementation dependency from build.gradle and adding Log to the DotExporterTest class, the test will pass, but there will be the info message: 'SLF4J: Defaulting to no-operation (NOP) logger implementation.' Therefore, I would recommend keeping Logback in the dependencies for proper logging functionality.
neotheprogramist
force-pushed
the
3-implement-file-storing-mechanism-for-todot-method-output-in-verkletrie
branch
2 times, most recently
from
59bec26 to
67477c6
Compare
…sentation in Dot format. Signed-off-by: Neo <[email protected]>
Signed-off-by: Neo <[email protected]>
…e possibility of displaying repeating edges, if 'true' show all adges, if 'false' don't display repeating edges Signed-off-by: Neo <[email protected]>
…overload in SimpleVerkleTrie Signed-off-by: Neo <[email protected]>
…sentation in Dot format. Signed-off-by: Neo <[email protected]>
…e possibility of displaying repeating edges, if 'true' show all adges, if 'false' don't display repeating edges Signed-off-by: Neo <[email protected]>
…ng StringBuilder usage with String.format() Signed-off-by: Neo <[email protected]>
…est'. Signed-off-by: Neo <[email protected]>
Signed-off-by: Neo <[email protected]>
Signed-off-by: Neo <[email protected]>
Signed-off-by: Neo <[email protected]>
…ify tests accordingly to read from files. Signed-off-by: Neo <[email protected]>
Signed-off-by: Neo <[email protected]>
Signed-off-by: Neo <[email protected]>
Signed-off-by: Neo <[email protected]>
…e, modify DotExporterTest Signed-off-by: Neo <[email protected]>
Signed-off-by: Neo <[email protected]>
…y in Node classes Signed-off-by: Neo <[email protected]>
…ck dependency versions to versions.gradle, small import fixes Signed-off-by: Neo <[email protected]>
Signed-off-by: Neo <[email protected]>
Signed-off-by: Neo <[email protected]>
Signed-off-by: Neo <[email protected]>
Signed-off-by: Neo <[email protected]>
Signed-off-by: Neo <[email protected]>
Signed-off-by: Neo <[email protected]>
neotheprogramist
force-pushed
the
3-implement-file-storing-mechanism-for-todot-method-output-in-verkletrie
branch
from
c2f01fe to
deee991
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes visoftsolutions#3