fix: Removed the comma when building a react app #17801
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gavinabu
changed the title
gavinabu
changed the title
|
The comma is from our formatter, as shown in CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the main.ts/main.js file on the line </React.StrictMode> there is an unneeded comma there. I'm not sure why it's there. Does not cause any errors or anything. I wonder how many vite apps were built and published with that comma there. This also saves 1 byte of precious storage, in total these commas have taken up 14 megabytes of storage over all downloads. There are plenty of pull requests to look through some are useful and some are well... a comma. Ta taa