Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Views Support Work for GA #17391

Open
3 tasks
harshit-gangal opened this issue Dec 13, 2024 · 0 comments
Open
3 tasks

Views Support Work for GA #17391

harshit-gangal opened this issue Dec 13, 2024 · 0 comments
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Milestone

Comments

@harshit-gangal
Copy link
Member

harshit-gangal commented Dec 13, 2024

View support was added in v18 with #11559 as experimental.

There are some rough edges we can resolve and call it a GA feature.

VTGate:

  • Enable views by default and deprecate the flag
  • Create/Update View: Look only for tables involved in the select query to determine the keyspace involved rather than the plan output as plan can have multi keyspace access (lookup table)
  • Rely on keyspace sharded and unsharded to determine if view can be created or not, over the flag value

VTTablet:
The enable views flag will remain, as this is used to send the view definition over the wire to VTGate for it to cache.
Ideally, we want VTTablet to determine if it is part of sharded or unsharded keyspace and send the details if it belongs to sharded keyspace.

@harshit-gangal harshit-gangal added this to the v22.0.0 milestone Dec 13, 2024
@harshit-gangal harshit-gangal added Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

No branches or pull requests

1 participant