Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to specify different verbs for different resources in single command ? #10

Open
isindir opened this issue Mar 13, 2022 · 8 comments

Comments

@isindir
Copy link

isindir commented Mar 13, 2022

How to specify different verbs for different resources in single command ?

Also would be usefull to be able able to give a custom name or prefix for the temp rbac setup

@viveksinghggits
Copy link
Owner

Hi @isindir,
thanks for pointing that out, unfortunately specifying different verbs for different resources is not supported right now. And the main problem is how the CLI UX is going to look like. How exactly can user specify that.
About your second point, I agree, we should be able to specify the username atleast. I have created an issue to track that.
#8

@isindir
Copy link
Author

isindir commented Mar 13, 2022

@viveksinghggits it is possible to add repeated flags, for exmaple:

abc --flag param1 --flag param2

at the same time the whole set of verb + resource + name +namespace caould potentially take form of:

verbs:resources:name:namespace

@isindir
Copy link
Author

isindir commented Mar 13, 2022

btw, it would be usefull to log out location of "config" file, which looks more like a log file as well as add information about all resources created as part of each invocation of allow

@viveksinghggits
Copy link
Owner

@viveksinghggits it is possible to add repeated flags, for exmaple:

abc --flag param1 --flag param2

at the same time the whole set of verb + resource + name +namespace caould potentially take form of:

verbs:resources:name:namespace

Hi @isindir,
I designed it in that way so that people who are familiar with kubectl would not have to learn how akcess works. But let's see if people have requirement to specify different verbs for different resources we can consider changing design a bit.

@viveksinghggits
Copy link
Owner

btw, it would be usefull to log out location of "config" file, which looks more like a log file as well as add information about all resources created as part of each invocation of allow

Hi @isindir,
Since we have already specified the resources that we create here, I am not sure what else are you expecting. Can you please explain. We can specify in README where do we create the config file.

@isindir
Copy link
Author

isindir commented Mar 13, 2022

In the code it may create in tempdir or in home directory , the only way to know where it stores the data is reading code. I agree - list commad provides some information, and readme provides some extra, but it would better to have full list of created resourses via list as well as to know how to remove log file itself. The other problem - delete command does not provide -k switch, which made it impossible for me to remove all resources using utility created these resources.

@viveksinghggits
Copy link
Owner

Hi, thank you @isindir for the valuable inputs. I think we should try to solve this in steps. I think the first thing that I should try to resolve is making sure akcess delete honors the -k flag. What do you think. And then we can talk about other things as well. Do you mind raising another issue specifically to support -k flag for akcess delete.

@isindir
Copy link
Author

isindir commented Mar 13, 2022

@viveksinghggits I think flags like -k can be part of global flags which are passed before any specific sub-command can be issued and depending on actual sub-command may be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants