deploy-opsman-vm task fails

[gokeefe]

Issue

release: 0.23.8
iaas: VMware VSphere 6.5
pcf: opsman 2.0 to 2.1

Given the following values for OPSMAN_VM_FOLDER and GOVC_DATACENTER

GOVC_DATACENTER=VB2
OPSMAN_VM_FOLDER=PivotalCF_PRD-UAT/PivotalCF

the govc import.ova command fails because OPSMAN_VM_FOLDER cannot be found

govc import.ova -options=opsman_settings.json --folder="${OPSMAN_VM_FOLDER}" pcf-vsphere-2.1-build.389.ova
govc: folder 'PivotalCF_DEV-SIT/PivotalCF' not found

even though the full path is valid

govc vm.info -vm.ipath="${GOVC_DATACENTER}/vm/${OPSMAN_VM_FOLDER}/lxapp-d-pcfops01-2.0.19-20180807195441"
Name:           lxapp-d-pcfops01-2.0.19-20180807195441
  Path:         /VB2/vm/PivotalCF_DEV-SIT/PivotalCF/lxapp-d-pcfops01-2.0.19-20180807195441
  UUID:         423c1e51-6906-9c15-3c69-2d9b936154c2
  Guest name:   Other (32-bit)
  Memory:       8192MB
  CPU:          2 vCPU(s)
  Power state:  poweredOn
  Boot time:    2018-10-19 22:42:29.543572 +0000 UTC
  IP address:   10.128.40.46
  Host:         vb2-esx-prd28.test.local

The govc import.ova command on line 62 seems to be incompatible with the govc vm.info command on line 80?

Context

To workaround this issue, I've set the OPSMAN_VM_FOLDER to the full path of the folder, ie: /VB2/vm/PivotalCF_DEV-SIT/PivotalCF, and modified the rest of the deploy-opsman-vm task.sh to remove references to the GOVC_DATACENTER variable.

Expected result

deploy-opsman-vm should successfully deploy ops manager from ova, disconnect/shutdown the old ops manager, and power on the new one.

Current result

deploy-opsman-vm task fails on the import.ova step when unmodified

Possible Fix

Set OPSMAN_VM_FOLDER to the full path and remove references to GOVC_DATACENTER variable in deploy-opsman-vm task.sh

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.