You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As a consumer of @cds/react and @cds/core we were looking into the new-ish Signpost component and we have some feedback:
The anchor attribute must be a string (id reference) or HTMLElement. Other components such as CdsInput are able to hook up ids between the label and input, it would make a lot of sense for Signpost to have a similar capability. Even if it requires slots for the anchor vs the content like the modal's cds-modal-header and cds-modal-content. This would be a better experience for both web component users and React users, since it would support JSX elements "for free" unlike the current version. Even better yet would be built-in support for common triggers like CdsButton and CdsIconButton that handled events - this would also reduce the chances for some a11y issues (such as consumers making a Signpost on hover that doesn't respond to keyboard navigation too)
Example of what this might look like with inferred anchor cds-icon-button and slot for content, with no manual id associations required:
Similar to CdsModal there is no styling built into CdsSignpost for the contents. Things like header/body typography and spacing are left completely up to the consumer. It would be great to have supplemental components for this to keep typography and spacing consistent across similar signposts.
The docs are a bit of a mess, it seems the demo signpost gets stuck and must be manually deleted from the DOM, and the source for the demos are mostly internals or hidden implementations instead of real signpost code examples
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
As a consumer of
@cds/react
and@cds/core
we were looking into the new-ish Signpost component and we have some feedback:anchor
attribute must be a string (id reference) or HTMLElement. Other components such asCdsInput
are able to hook up ids between the label and input, it would make a lot of sense forSignpost
to have a similar capability. Even if it requires slots for the anchor vs the content like the modal'scds-modal-header
andcds-modal-content
. This would be a better experience for both web component users and React users, since it would support JSX elements "for free" unlike the current version. Even better yet would be built-in support for common triggers likeCdsButton
andCdsIconButton
that handled events - this would also reduce the chances for some a11y issues (such as consumers making a Signpost on hover that doesn't respond to keyboard navigation too)Example of what this might look like with inferred anchor
cds-icon-button
and slot for content, with no manual id associations required:Similar to CdsModal there is no styling built into CdsSignpost for the contents. Things like header/body typography and spacing are left completely up to the consumer. It would be great to have supplemental components for this to keep typography and spacing consistent across similar signposts.
The docs are a bit of a mess, it seems the demo signpost gets stuck and must be manually deleted from the DOM, and the source for the demos are mostly internals or hidden implementations instead of real signpost code examples
Beta Was this translation helpful? Give feedback.
All reactions