Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package newer python-language-server and remove the old one #34192

Closed
jgarte opened this issue Nov 22, 2021 · 9 comments
Closed

Package newer python-language-server and remove the old one #34192

jgarte opened this issue Nov 22, 2021 · 9 comments

Comments

@jgarte
Copy link
Contributor

jgarte commented Nov 22, 2021

This is the new fork that is being maintained: https://github.com/python-lsp/python-lsp-server

See: palantir/python-language-server#935 and #34180.

@foopub
Copy link
Contributor

foopub commented Nov 23, 2021

If you're up for it you should have a go at making the template for the python-lsp-server package and just make a pull request. I've been using python-lsp-server installed with pip so haven't really had the motivation, but I don't mind having a go at it tomorrow.

@k4leg seeing as you're the maintainer of python3-language-server, what do you think?

@jgarte
Copy link
Contributor Author

jgarte commented Nov 23, 2021

I might not be able to work on it for a week or so. It depends on when I find the free time. Feel free to try it.

If you get stuck or have any questions you can post them here. I can help with testing also.

@camoz
Copy link

camoz commented Mar 6, 2022

BTW it would be cool if the new packge could be named exactly like the project python-lsp-server, and not python3-lsp-server or something... that makes it easier to find.

@paper42
Copy link
Member

paper42 commented Mar 6, 2022

BTW it would be cool if the new packge could be named exactly like the project python-lsp-server, and not python3-lsp-server or something... that makes it easier to find.

On void, all python3 packages are prefixed with python3-, prefix python- would mean it's a Python 2 package.

@camoz
Copy link

camoz commented Mar 6, 2022

Oh ok. Is there any chance this will be changed in the future? Python 2 is EOL for over two years now... No pressure, just curious. :)

@Duncaen
Copy link
Member

Duncaen commented Mar 6, 2022

Oh ok. Is there any chance this will be changed in the future? Python 2 is EOL for over two years now... No pressure, just curious. :)

No renaming packages is a pain and doing this again if there is a python4 or something like that would be annoying.

@camoz
Copy link

camoz commented Mar 6, 2022

AIUI Python 4 is unlikely to happen at all, but I understand that people are spoiled from the 2->3 transition... It just seems unfortunate to me that if you search for the official project names like python-lsp-server or the current python-language-server, you get no results.

Also, why is renaming packages a pain? Isn't there a replaces= field in templates?

@Duncaen
Copy link
Member

Duncaen commented Mar 6, 2022

Also, why is renaming packages a pain? Isn't there a replaces= field in templates?

This just makes xbps replace the other package if the replacing package is being installed, i.e. through a dependency.
If you've manually installed python3-foo and nothing depends on it that would pull in the new package with the replaces directive into the xbps transaction it will never be installed or replace any package.

This can not be changed as this is also used by some packages that act as an alternative for another package, i.e. nvidia used to replace the mesa libgl implementations, so by installing nvidia you can replace the open source implementation, without having to force break and uninstall the opensource implementation first.

The only alternative to this is to use "transaction dummy packages", i.e. a meta package with the old name and a higher version that depends on the new package name which then in turn replaces the old name.
But this is kinda buggy in the current xbps release and drops the manual/automatic install mode sometimes.

But that is also not a nice solution and would require us to ship 937 dummy packages for who knows how long until everyone updated their system.

Its simply not worth it with the current solutions to rename all those packages.

@camoz
Copy link

camoz commented Mar 6, 2022

Understood, thank you for the nice explanation, appreciated!

CameronNemo added a commit to CameronNemo/void-packages that referenced this issue Apr 2, 2022
Substitute for python3-language-server

Fixes void-linux#34192
CameronNemo added a commit to CameronNemo/void-packages that referenced this issue Apr 2, 2022
Substitute for python3-language-server

Fixes void-linux#34192
CameronNemo added a commit to CameronNemo/void-packages that referenced this issue Apr 2, 2022
Substitute for python3-language-server

Fixes void-linux#34192
basploeger pushed a commit to basploeger/void-packages that referenced this issue Apr 8, 2022
Substitute for python3-language-server

Fixes void-linux#34192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants