Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for committing untracked files #138

Closed
wants to merge 2 commits into from
Closed

feat: add support for committing untracked files #138

wants to merge 2 commits into from

Conversation

joshuahiggins
Copy link

Adds boolean option of commitUntrackedFiles with a default value of false. When set to true, the following git command is added into the bump-dry and bump flow: git add [opts.commitFiles].

As git add and git commit have different shorthands for --all, there is a check that converts -a to --all if a user has this value entered for commitFiles. The documentation has been updated to state --all in place of the shorthand to reduce confusion.

Closes #120

@eddiemonge
Copy link
Collaborator

I'd still prefer something that matches what should go in instead of a blind commit all

@cvbuelow
Copy link

Any reason this hasn't been merged yet? @eddiemonge it only adds all files if you tell it to.

@joshuahiggins
Copy link
Author

@cvbuelow, he made it pretty clear in the other thread that he doesn't feel comfortable allowing people use -a for adding untracked files, even if there's an explicit option for them to opt in to. I have no interest in updating this pull request to use glob patterns, so I've just forked the repo for personal projects until a time when grunt-bump allows this functionality on it's own.

@eddiemonge eddiemonge closed this Aug 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to add untracked files before a commit is performed
3 participants