Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pjax 部署推送 #268

Merged
merged 4 commits into from
May 3, 2020
Merged

Pjax 部署推送 #268

merged 4 commits into from
May 3, 2020

Conversation

inkss
Copy link
Member

@inkss inkss commented May 3, 2020

兼容性列表:

  • 封面:无法控制封面显示,现在只能做到:要么所有页面都显示,要么都不显示。
  • 搜索:仅测试过 HexoSearch ,其它理论可以,大致是这样。嗯,是的。
  • 评论:仅适配了 valine ,懒。
  • mathjax
  • instant_page
  • backstretch
  • aplayer
  • clipboard
  • scrollreveal
  • fancybox
  • lazyload
  • busuanzi
  • nodewaves
  • comment_typing
  • highlight

备注:

  • 音乐播放器:我将文章页面的自动播放去除了,只保留了非文章内的自动播放。
  • 懒加载:做了一版兼容,等待上游更新后再继续处理,详见:hexo-lazyload-image/issues/21
  • 公式:上游有错误,但是测试通过了 Pjax 兼容,详见:Valine/issues/305
  • 评论:移除了 app.js 中对导航栏评论按钮的控制,原因见:L137
  • 其它:或许还有没发现的潜在兼容性问题吧。

额外:

  • 修复内容:友链页追加了页脚处的 meta 显示。
  • 修复内容:图片点击放大,原逻辑无法处理形如 ![]() 写法的图片放大。
  • 修复内容:将图片的描述信息放到了 fancybox 的显示里。

@xaoxuu
Copy link
Member

xaoxuu commented May 3, 2020

非常感谢大佬 🤝

@xaoxuu xaoxuu merged commit 8a6d23b into volantis-x:pjax May 3, 2020
@inkss
Copy link
Member Author

inkss commented May 3, 2020

lazyload 这块我改了点,之前有点判断失误了,emm,链接在这个:hexo-lazyload-image/issues/21

现在我是手动修改了模块里的 simple-lazyload.js 文件,把 images 的获取扔到函数里了,如果觉得麻烦的话,可以先不理 399294a 里有关懒加载的提交。

@xaoxuu
Copy link
Member

xaoxuu commented May 3, 2020

我在本地预览了一下,发现有些地方UI有问题:

image.png

@xaoxuu
Copy link
Member

xaoxuu commented May 3, 2020

评论加载不出来,图片加载的极慢,我切换回master分支之后就正常了,应该不是网络的问题。

@inkss
Copy link
Member Author

inkss commented May 3, 2020

你看看我的网站呢,这次提交 merged 到我主分支了。

image

@inkss
Copy link
Member Author

inkss commented May 3, 2020

对了,本地的 valine 版本好像有问题

@xaoxuu
Copy link
Member

xaoxuu commented May 3, 2020

导航栏跳转到评论的按钮可以拿出来放到【回到顶部】按钮旁边;或者干脆不要,正好避免了文章都不看就直接去评论的情况

@inkss
Copy link
Member Author

inkss commented May 3, 2020

那样桌面端,二级导航只有标题在,总觉得有点空荡荡的

@xaoxuu
Copy link
Member

xaoxuu commented May 3, 2020

沉浸式体验啊

@inkss
Copy link
Member Author

inkss commented May 3, 2020

啊哈哈哈哈,好吧,设计方面我不太在行。这里的判断不是因为有些文章允许了无评论,这种情况的也不多吧?大概 😅

@xaoxuu
Copy link
Member

xaoxuu commented May 3, 2020

image.png
我觉得这样反而更美观了

不重要的功能就直接砍掉

@inkss
Copy link
Member Author

inkss commented May 3, 2020

不过要是说到沉浸式,我是特别喜欢这个的效果:这个主题里的 阅读模式

@xaoxuu
Copy link
Member

xaoxuu commented May 3, 2020

https://github.com/theme-volantis/theme-volantis.github.io
我建了一个 org 仓库,这个用来发 volantis-docs + pjax 生成的页面

我邀请你了,你接受一下,看看有没有仓库写入权限

@inkss
Copy link
Member Author

inkss commented May 3, 2020

嗯 好了 √

@xaoxuu
Copy link
Member

xaoxuu commented May 3, 2020

在这个仓库里面操作: https://github.com/theme-volantis/volantis-docs

@xaoxuu
Copy link
Member

xaoxuu commented May 3, 2020

我刚试了一下,用SSH方式可以,HTTPS方式提示我没有权限。

[email protected]:theme-volantis/volantis-docs.git

已经部署好了: https://theme-volantis.github.io/

@inkss
Copy link
Member Author

inkss commented May 3, 2020

好的

@inkss
Copy link
Member Author

inkss commented May 3, 2020

你用的 node 环境是几?

@xaoxuu
Copy link
Member

xaoxuu commented May 3, 2020

v12.16.1 LTS

你用最新的 LTS 版应该不会冲突: https://nodejs.org/dist/v12.16.3/node-v12.16.3.pkg

@inkss
Copy link
Member Author

inkss commented May 3, 2020

这是什么鬼情况,我用的是 13.7.0

image

@xaoxuu
Copy link
Member

xaoxuu commented May 3, 2020

那你用的不是 LTS 版
image.png

@inkss
Copy link
Member Author

inkss commented May 3, 2020

我切下版本

@inkss
Copy link
Member Author

inkss commented May 3, 2020

我部署了一版本,你看看,封面先给改成了半屏,以这个为验证,啊,我讨厌缓存

@xaoxuu
Copy link
Member

xaoxuu commented May 3, 2020

👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants