Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method of finding RTC device is inflexible and assumes guest kernel has RTC_HCTOSYS=y #14

Open
voutilad opened this issue Jan 26, 2021 · 0 comments
Open

Method of finding RTC device is inflexible and assumes guest kernel has RTC_HCTOSYS=y #14

voutilad opened this issue Jan 26, 2021 · 0 comments

Comments

@voutilad
Copy link
Owner

virtio_vmmci/virtio_vmmci.c

Line 145 in b2caad3

struct rtc_device *rtc = rtc_class_open(CONFIG_RTC_HCTOSYS_DEVICE);

While we can (for now?) assume an RTC device exists, it's possible the guest might have RTC_SYSTOHCT=y set instead, meaning we should be passing RTC_SYSTOHC_DEVICE to rtc_class_open()
voutilad added a commit that referenced this issue Jan 26, 2021
@voutilad
increase chances of finding the rtc device
74cbbc4 
Related to #14, on some systems we can't find the RTC device due to the
kernel config not having CONFIG_RTC_HCTOSYS_DEVICE defined, so try
falling back to the alternative CONFIG_RTC_SYSTOHC_DEVICE.

Not sure yet how to handle this in general, so this is a short term fix.
For instance, the driver will still schedule the work function for
synchronizing the clock and respond to sync commands. Wasteful.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@voutilad