Skip to content

Commit

Permalink
Merge pull request #618 from voxel51/azure-extra-cloud-client-kwargs
Browse files Browse the repository at this point in the history
Azure extra cloud client kwargs
  • Loading branch information
swheaton authored Feb 12, 2024
2 parents 0c92ec6 + 78c67ab commit e7110e0
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
9 changes: 6 additions & 3 deletions eta/core/storage.py
Original file line number Diff line number Diff line change
Expand Up @@ -2625,14 +2625,17 @@ class AzureStorageClient(
strategy used by this class.
"""

def __init__(self, credentials=None, max_pool_connections=None):
def __init__(self, credentials=None, max_pool_connections=None, **kwargs):
"""Creates an AzureStorageClient instance.
Args:
credentials: the credentials to use. If not provided, this is
automatically loaded as described in `NeedsAzureCredentials`
max_pool_connections: an optional maximum number of connections to
keep in the connection pool
**kwargs: optional configuration options for
`azure.identity.DefaultAzureCredential(**kwargs)` or
`azure.identity.ClientSecretCredential(**kwargs)`
"""
if credentials is None:
credentials, _ = self.load_credentials()
Expand Down Expand Up @@ -2685,10 +2688,10 @@ def __init__(self, credentials=None, max_pool_connections=None):
credential = account_key
elif tenant_id and client_id and client_secret:
credential = azi.ClientSecretCredential(
tenant_id, client_id, client_secret
tenant_id, client_id, client_secret, **kwargs
)
else:
credential = azi.DefaultAzureCredential()
credential = azi.DefaultAzureCredential(**kwargs)

if account_url is None:
if account_name is None:
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
from wheel.bdist_wheel import bdist_wheel


VERSION = "0.12.4"
VERSION = "0.12.5"


class BdistWheelCustom(bdist_wheel):
Expand Down

0 comments on commit e7110e0

Please sign in to comment.