-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customisation Sync timestamp changes lead to excessive updates #475
Comments
Thank you for your very detailed report! This report quite helps me! As you mentioned, I missed the following two logics for skipping non-changed files:
And one more thing, the differences in time are also shown correctly. This has been fixed at v0.23.20. Would you mind if I ask you to check the fixes, please? |
On a side note, from a usability perspective it would help a lot to only display files whose contents have changed. I have 21 plugins, and it takes a while to scroll down to see what files may or may not have changed. The ideal behaviour for me would be:
This way, if I get a notification that new configuration is available, I can open the dialog and quickly see what the relevant changes were. The more plugins installed, the more useful this behaviour would be. Is this something you would consider? |
I also have a question about the four options for each file:
The Automatic option does not seem to do anything. If I enable that for a file, I sometimes get a notification that a hidden file was updated, but the file contents are not changed. Any settings I changed do not propagate to a device with Automatic selected. If I change it back to Selective, I can manually update it fine. How is Automatic supposed to work? |
maybe I configured something wrong (half of the settings are described unclearly), but when opening obsidian makes its settings seem new, but in fact the new settings from the database do not have time to arrive and the plugin considers them obsolete (as I understood from the logs). as a result, new changes are rolled back when opening another device, as happens with iconize |
Sorry for being late!
This means And, some mtime problems have been fixed in recent versions. I am sorry to trouble you, but could you check if the same problem occurs again? P.S. I found that handling mtime is necessary in some cases. So, the item can be selected even if there is only a difference in mtime. |
I think I saw it again about a week ago, specifically:
I can certainly keep an eye out for it and capture some more screenshots and data from the CouchDB database when it happens again. |
I just had this happen again. Since it seems to be a separate issue from this one, I have logged a separate issue for under #506. |
Abstract
I recently switched from syncing hidden files to using customisation sync.
When customisation sync updates a file, it seems to update the timestamp of the file to the time the local file was modified. This is different to the way LiveSync updates
.md
files in the vault.On top of that, customisation sync seems to both notify and update files when the timestamp of a file has changed. This leads to excessive updates of config files.
The only way around this is to "Select All Shiny" and manually apply individual changes where the contents have changed. This is something which should really be automatic, as it is a tedious process to do this each time.
Expected behaviour
Actually happened
With two devices, this is kind of manageable, but I sync four devices (desktop, laptop, iPhone, iPad), so this issue is magnified because one small configuration changes requires me to go back and forth between the four devices multiple times until the changes have been applied.
Reproducing procedure
Report materials
Report from the LiveSync
Report from hatch
Plug-in log
Plug-in log
Screenshots
Here is an example showing files where the configuration has not changed, but the timestamps are different:
Other information, insights and intuition.
Launching Obsidian also seems to update the last modified timestamps for several files, such as
app.json
,appearance.json
, etc.This adds to the excessive update notifications on other devices. Since these timestamp changes are beyond the control of this plugin, perhaps ignoring timestamp changes and just looking at the file contents is the most robust solution.
The text was updated successfully, but these errors were encountered: