Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many Test cases? #23

Open
Lewih opened this issue Mar 18, 2022 · 6 comments
Open

Too many Test cases? #23

Lewih opened this issue Mar 18, 2022 · 6 comments
Assignees

Comments

@Lewih
Copy link
Collaborator

Lewih commented Mar 18, 2022

Is it possible to collapse many test cases generated by a parametrised test into a single more sophisticated test while preserving a meaningful reframe log output?

Is it necessary? Different test groups can be run in different moments (using tags) reducing the number of test cases run simultaneously.

@Lewih Lewih mentioned this issue Mar 18, 2022
@Lewih Lewih assigned smoors and unassigned smoors Mar 18, 2022
@stevenvdb
Copy link
Contributor

To be clear: I have no problem with many test cases and I completely understand the logic that you want a test to check exactly one thing. What we should keep an eye on, is that the number of batch jobs submitted when running the test suite does not grow exponentially. There is for example a separate batch job for each environment variable that is tested. Currently there are 40 batch jobs submitted when running the entire suite, which is still manageable. It would be nice if ReFrame would support running multiple tests within a single job for this purpose.

@Lewih
Copy link
Collaborator Author

Lewih commented Apr 20, 2022

Surely would be handy to have different test cases in a single job. investigating.

@smoors
Copy link
Collaborator

smoors commented Apr 21, 2022

an alternative would be to launch ReFrame from inside a job, and use the 'local' partition to run the tests.
of course, that does not work for tests that must run in the login node, but those test run in the 'local' partition anyway.

@Lewih
Copy link
Collaborator Author

Lewih commented Apr 21, 2022

Let's use @stevenvdb 's idea: performance test report as a mean to check True and False validation tests.

From Slack: No-one is aware of a way to submit multiple tests in a single job.

@Lewih
Copy link
Collaborator Author

Lewih commented May 1, 2022

they are working on a more complete test logging.

from slack:

Technically, full test logging is currently not available except through performance logging. We have an feature request to change this and support proper test case logging, regardless of whether it’s a performance test or not.

link

@stevenvdb
Copy link
Contributor

stevenvdb commented May 19, 2022

For now we will keep one test per job. Perhaps in the future this will change if ReFrame offers better support for it. This can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants