Implement bucket handling #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kidswiss
requested review from
a team,
TheBigLee,
zugao and
wejdross
and removed request for
a team
The bucket handling is more or less 1:1 from provider-exoscale. This includes the checks to determine if the bucket already exists and the deletion policy handling.
Unlike "real" cloud-providers, this won't cost us anything to run the e2e tests often.
wejdross
reviewed
Aug 29, 2023
wejdross
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The bucket handling is more or less 1:1 from provider-exoscale. This includes the checks to determine if the bucket already exists and the deletion policy handling.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog