Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the default value of the prop variant in the Tag component #1740

Open
beatrizmilhomem opened this issue Jul 17, 2024 · 0 comments · May be fixed by #1854
Open

Change the default value of the prop variant in the Tag component #1740

beatrizmilhomem opened this issue Jul 17, 2024 · 0 comments · May be fixed by #1854
Assignees
@viniciuslagedo
Labels
bug Something isn't working dev Indicates that the issue or pull request involves engineering considerations good first issue Great for new-comers

Comments

@beatrizmilhomem
Copy link
Contributor

The default value should be gray secondary because it's the most common scenario.
https://620e870c28c4ae003a705d42-xcwifphopc.chromatic.com/?path=/story/components-tag--show
@beatrizmilhomem beatrizmilhomem added the bug Something isn't working label Jul 17, 2024
@beatrizmilhomem beatrizmilhomem moved this to Backlog in Shoreline Jul 17, 2024
@beatrizmilhomem beatrizmilhomem added dev Indicates that the issue or pull request involves engineering considerations light labels Jul 17, 2024
@davicostalf davicostalf added good first issue Great for new-comers dev wanted Indicates that additional help or expertise from engineering is needed to address the issue. and removed dev wanted Indicates that additional help or expertise from engineering is needed to address the issue. labels Aug 6, 2024
viniciuslagedo added a commit that referenced this issue Aug 22, 2024
@viniciuslagedo
fix(tag): change default variant to secondary
6d29a0a 
The most used case of this component is with gray color and secondary variant so we changed it

BREAKING CHANGE: Tag component without variant will render with secondary prop, so all the
implementation now need to change to explicity set it to primary to stay in the same way

fix #1740
@viniciuslagedo viniciuslagedo linked a pull request Aug 22, 2024 that will close this issue
Open
@lucasaarcoverde lucasaarcoverde moved this from Backlog to Active in Shoreline Aug 22, 2024
viniciuslagedo added a commit that referenced this issue Aug 24, 2024
@viniciuslagedo
fix(tag): change default variant to secondary
f86ad7b 
The most used case of this component is with gray color and secondary variant so we changed it

BREAKING CHANGE: Tag component without variant will render with secondary prop, so all the
implementation now need to change to explicity set it to primary to stay in the same way

fix #1740
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viniciuslagedo viniciuslagedo

Labels
bug Something isn't working dev Indicates that the issue or pull request involves engineering considerations good first issue Great for new-comers
Projects
Shoreline
Status: Active
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: tag default variant vtex/shoreline
4 participants
@viniciuslagedo @davicostalf @lucasaarcoverde @beatrizmilhomem