Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: augment vue rather than @vue/runtime-core #451

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

danielroe
Copy link
Contributor

In line with vuejs/router#2295 and nuxt/nuxt#28542, this moves to augment vue rather than @vue/runtime core.

This is now officially recommended in the docs and it must be done by all libraries or it will break types for other libraries.

@xollaborator
Copy link

@hunterliu1003 Is there a chance to relase a patch with this change only? As I have checked in my repo, it is responsible for hundreds of errors in vue-tsc, because it is breaking types for $router (vue-router) and $t (i18n). I believe many more people will benefit and probably many did not figure out yet what dependency is breaking vue types in their case.

I hope that makes it easier to understand the impact of merging PR from Daniel. Thank you.

@hunterliu1003
Copy link
Member

@hunterliu1003 Is there a chance to relase a patch with this change only? As I have checked in my repo, it is responsible for hundreds of errors in vue-tsc, because it is breaking types for $router (vue-router) and $t (i18n). I believe many more people will benefit and probably many did not figure out yet what dependency is breaking vue types in their case.

I hope that makes it easier to understand the impact of merging PR from Daniel. Thank you.

Thanks for the reminder. I will release a patch version as soon as possible. I had a new baby last month and life got very busy.

@hunterliu1003 hunterliu1003 merged commit 864cf89 into vue-final:master Sep 10, 2024
2 checks passed
@xollaborator
Copy link

@hunterliu1003 congratulations! thank you for so fast reply and all the best for your family :)

@hunterliu1003
Copy link
Member

@xollaborator
Thanks ❤️
Released in v4.5.5

@danielroe danielroe deleted the vue-augment branch September 10, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants