fix(v-model): vModelSelect work with custom getter and setter edge case #12428
+63
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-ssr
@vue/compiler-sfc
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
yangxiuxiu1115
changed the title
|
LGTM. For sure this behavior is consistent with vue2 |
edison1105
added
scope: v-model
🍰 p2-nice-to-have
edison1105
changed the title
edison1105
approved these changes
Nov 19, 2024
| @@ -233,7 +239,7 @@ export const vModelSelect: ModelDirective<HTMLSelectElement, 'number'> = { | |||
| el[assignKey] = getModelAssigner(vnode) | |||
| }, | |||
| updated(el, { value }) { | |||
| if (!el._assigning) { | |||
| if (!el[assigningKey] || toRaw(value) !== el[assignValueKey]) { | |||
There was a problem hiding this comment.
Using an equality check might be problematic if the collection is modified, rather than replaced.
For example:
I'm not sure how important handling cases like these is. The change doesn't make them any worse.
| @@ -202,24 +209,23 @@ export const vModelRadio: ModelDirective<HTMLInputElement> = { | |||
| export const vModelSelect: ModelDirective<HTMLSelectElement, 'number'> = { | |||
| // <select multiple> value need to be deep traversed | |||
| deep: true, | |||
| created(el, { value, modifiers: { number } }, vnode) { | |||
| created(el, { value, oldValue, modifiers: { number } }, vnode) { | |||
There was a problem hiding this comment.
I think oldValue is unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #12425