Enable Style Guide nav item #3101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vuejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@runyasak the style guide is still WIP so we intentionally didn't show this one in the navbar. |
|
@NataliaTepluhina I understand. Thank you for reviewing my PR. Additionally, I’m really thrilled and interested in the Vue Style Guide, especially for Vue 3. I’m looking forward to it. If there’s anything I can contribute to this topic, please let me know. 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
Vue style guide has been very helpful for me and my team as a reference for work.
I've been following this guide since Vue 2, as the guideline in the documentation.
However, for Vue 3, the style guide is not prominently accessible in the documentation.
I accidentally found it in some parts of the docs, but it would be helpful if it were accessible from the navbar, as it was with Vue 2.
Proposed Solution
I’ve removed the comment from the style guide navbar item to make it visible in the navbar.
I’m unsure if there was a specific reason it was hidden.
Please let me know if you have any feedback or suggestions.
Screenshots
Before
After
https://github.com/user-attachments/assets/68ee6c0c-48c8-49cb-ae1e-f42f30987f58