Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanups #1

Open
7 tasks done
joreg opened this issue Nov 14, 2024 · 1 comment
Open
7 tasks done

Cleanups #1

joreg opened this issue Nov 14, 2024 · 1 comment
Assignees
@antongit

Comments

@joreg
Copy link
Member

joreg commented Nov 14, 2024 •
edited by antongit
Loading

  • hide sysex input/output
  • hide i2c delay input -> only show in i2c help
  • hide config input -> only mention in a help
  • check sample rate input: what unit/range is it? document what it is controlling exactly
  • make explanation patch for FirmataDevice node
  • add tag "arduino" to FirmataDevice node
  • check why typing "arduino" in helpbrowser doesn't show this pack
@antongit
Copy link
Member

@joreg
"check why typing "arduino" in helpbrowser doesn't show this pack" - we are not including pack's tags into the search. I guess we've decided against it, because it will lead to too many positives. Only tags for individual howtos added to the help.xml are included in the search.

antongit added a commit that referenced this issue Nov 18, 2024
@antongit
Adds to #1:
247d6bf 
- Sysex Input/Output pins are optional
- I2C Delay is hidden
- Custom Config is hidden
- Sample Rate (now hidden) is set to 30, added helptext and fixed internally: Sample Rate is converted to the Sampling Interval.
- Added `Explanation An Overview` for the FirmataDevice node
- Added help.xml to set tags to the HowTos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antongit antongit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joreg @antongit