feat[tool]: support storage layouts via json and vyz #4370
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4370 +/- ##
==========================================
- Coverage 91.31% 88.83% -2.49%
==========================================
Files 113 113
Lines 16061 16092 +31
Branches 2703 2709 +6
==========================================
- Hits 14666 14295 -371
- Misses 964 1286 +322
- Partials 431 511 +80 ☔ View full report in Codecov by Sentry. |
…/storage_layout_json
This reverts commit 08f0396.
|
@charles-cooper requesting a review before I update the docs |
| storage_layout_overrides: dict[PurePath, StorageLayout] = {} | ||
|
|
||
| for path, value in input_dict.get("storage_layout_overrides", {}).items(): | ||
| if path not in input_dict["sources"]: |
There was a problem hiding this comment.
i guess we can have contracts which do not have corresponding override files
There was a problem hiding this comment.
i think that's fine, since each key in "sources" is a compilation target.
There was a problem hiding this comment.
looks overall pretty good to me. left a few comments. @cyberthirst could you also take a look?
| @@ -12,6 +12,7 @@ | |||
| from vyper.compiler.settings import Settings | |||
There was a problem hiding this comment.
for verification, storage layout override can (and should) affect integrity hash.
charles-cooper
changed the title
What I did
Resolves #4367
How I did it
solc_jsonand archive outputs, emit the storage layout as output if it was overriden.solc_jsonand archive inputs if provided.How to verify it
See tests.
Commit message
Description for the changelog
Cute Animal Picture