Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: correct rendering of nested algo steps #1692

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

jugglinmike
Copy link
Contributor

@jugglinmike jugglinmike commented Sep 12, 2023

Bikeshed version 3.14.5 (the lastest at the time of writing) requires four spaces of indentation for a list item to be rendered as part of a nested list. This specification inconsistently uses just two spaces of indentation, resulting innacurracies in the rendered document.

For instances, the enable()
method
appears as a flat list of sequential steps:

  1. Let promise be a new promise.
  2. Run the following steps in parallel:
  3. Let registration be this's associated service worker registration.
  4. If registration’s active worker is null, reject promise with an "InvalidStateError" DOMException, and abort these steps.
  5. Set registration’s navigation preload enabled flag.
  6. Resolve promise with undefined.
  7. Return promise.

Insert additional spaces so that nested lists are rendered appropriately in the published document.


Preview | Diff

Bikeshed version 3.14.5 (the lastest at the time of writing) requires
four spaces of indentation for a list item to be rendered as part of a
nested list. This specification inconsistently uses just two spaces of
indentation, resulting innacurracies in the rendered document.

For instances, [the enable()
method](https://w3c.github.io/ServiceWorker/#navigation-preload-manager-enable)
appears as a flat list of sequential steps:

>  1. Let promise be a new promise.
>  2. Run the following steps in parallel:
>  3. Let registration be this's associated service worker registration.
>  4. If registration’s active worker is null, reject promise with an "InvalidStateError" DOMException, and abort these steps.
>  5. Set registration’s navigation preload enabled flag.
>  6. Resolve promise with undefined.
>  7. Return promise.

Insert additional spaces so that nested lists are rendered appropriately
in the published document.
Copy link
Collaborator

@mkruisselbrink mkruisselbrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@w3cbot
Copy link

w3cbot commented Sep 12, 2023

mkruisselbrink marked as non substantive for IPR from ash-nazg.

@mkruisselbrink mkruisselbrink merged commit 89695bb into w3c:main Sep 12, 2023
1 check passed
github-actions bot added a commit that referenced this pull request Sep 12, 2023
SHA: 89695bb
Reason: push, by mkruisselbrink

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@jugglinmike
Copy link
Contributor Author

Sure thing!

@jugglinmike jugglinmike deleted the editorial-substep-rendering branch September 12, 2023 22:28
github-actions bot added a commit to asleekgeek/ServiceWorker that referenced this pull request Sep 12, 2023
SHA: 89695bb
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants