-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change mapping of h1-h6 and hgroup #123
Comments
@annevk I have the same reservations about supporting the implementation of this as I have always had and agree with much of what @sideshowbarker says in whatwg/html#3499 (comment) and subsequent comments. When I look at example of For example, when I run a query on the latest webdevdata data some examples found in the first 100 results: I don't see how making the whole content into a heading in these and other cases improves the semantics.
|
What percentage of (Note also that |
FYI to help with answering that I just now added logging of URLs for
I agree that |
@sideshowbarker thanks, look forward to reviewing the data.
while I agree, it is an important aspect of this issue to update the mapping, as |
Related to whatwg/html#7829. Assuming this PR lands, an `hgroup` will only allow a single heading and paragraph elements <small>(and script-supporting elements, but that's not relevant here)</small> to represent sub-heading information. However, as there are _lots_ of instances of `hgroup` in the wild where multiple headings are used - as this was allowed prior to the HTML PR, these will become invalid markup patterns, and indicating that the headings of lower level be treated as `p` elements will at least mitigate for this change. For additional discussion: - should `hgroup` be exposed as a 'heading group' or even just a 'group' to define the boundaries of where the hgroup content starts/stops - should `p` elements or errant extra `h#` elements be exposed as 'sub headings'. `doc-subtitle` could potentially be used - though I'm not sure if that is actually appropriate, as we _don't_ want the subheadings to be exposed as 'headings' as some of the mappings for `doc-subtitle` would seem to indicate might be the result of mapping to this role. This could potentially be related to what dpub ARIA roles should be brought back into ARIA proper - e.g., `role=subheading` this effectively resolves #123 this may well help resolving w3c/aria-practices#1157
Provided implementers are on board with whatwg/html#3499 as a way of fixing whatwg/html#83 (comment), the mappings for these elements will need to change as well. This should be rather easy to do for these elements on top of the "heading level" concept they will get once that PR lands.
I figured I'd raise this somewhat early so a) we don't forget about it and b) I might be able to get more feedback this way.
The text was updated successfully, but these errors were encountered: