Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update intention for insertReplacementText to include writing suggestions #149

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

sanketj
Copy link
Member

@sanketj sanketj commented Dec 22, 2023

whatwg/html#9065 proposes the addition of a new attribute called writingsuggestions to control UA-provided writing assistance. When suggestions provided by the UA are accepted by the user, an input event is fired and, per discussion here, insertReplacementText was determined to be the right input type. This change updates the intention of insertReplacementText to include writing suggestion insertions.

Spec PR to introduce new attribute: whatwg/html#10018


Preview | Diff

@johanneswilm johanneswilm merged commit 547d35c into w3c:gh-pages Jan 9, 2024
2 checks passed
@marcoscaceres
Copy link
Member

Please make sure when updating things that affect browser, browser bugs are filed. 🙏 It would have been nice to have a bug filed on WebKit when this change got made.

Can I suggest this group start using a pull request template like:
https://github.com/w3c/geolocation-api/blob/main/.github/PULL_REQUEST_TEMPLATE.md

@marcoscaceres
Copy link
Member

Also, it would have been good to involve WebKit folks in this discussion before merging so we could have evaluated if this is the best approach (not saying it's not... just that we are now dealing with fallout of not having discussed the events related to writingsuggestions and what should actually fire and if this is even web compatible)

@johanneswilm
Copy link
Contributor

johanneswilm commented Mar 22, 2024

@marcoscaceres Apple did participate in the discussion of this change in the Web Editing Working Group. Subsequently the Whatwg determined the final name of the attribute.
Should we additionally have included someone specific from Webkit?

@marcoscaceres
Copy link
Member

Yeah, it would be great if we could this template in place:
https://github.com/w3c/geolocation-api/blob/main/.github/PULL_REQUEST_TEMPLATE.md

And make sure bugs are always filed when there is a normative spec change.

@johanneswilm
Copy link
Contributor

@marcoscaceres I am not sure that template works well with how we work in this WG given that we talk through each issue with representatives of each browser in the case of all those documents that are not just experimental in nature before they are added.

I can bring this as well as the question of why some browser representatives have not filed bugs with their respective browsers up at the next call. It sounds like some routines there could be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants