You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems potentially useful to pass an element directly to cropTo instead of a a CropTarget, especially if CropTarget is created asynchronously.
One potential issue is if at some point, it is found good to have a CropTarget getter on the track itself.
The text was updated successfully, but these errors were encountered:
It seems potentially useful to pass an element directly to cropTo instead of a a CropTarget, especially if CropTarget is created asynchronously.
I think it's a good idea. It's a non-blocking ergonomics improvement that affects only some cases. I'm marking it as such.
One potential issue is if at some point, it is found good to have a CropTarget getter on the track itself.
Resolution: Make cropTo(Element) implicitly create a CropTarget behind the scenes, and the getter will return that token, with no observable difference to the program between whether cropTo(Element) or cropTo(CropTarget) was previously called.
Noteworthy: An implicitly minted CropTarget is how Chrome would implement this anyway, and most likely other UAs as well.
See #11 (comment) for why I think this special-casing is bad, and a symptom of having an API shape so unappealing in the first place that this issue is considering adding a second one as a workaround for it.
It seems potentially useful to pass an element directly to cropTo instead of a a CropTarget, especially if CropTarget is created asynchronously.
One potential issue is if at some point, it is found good to have a CropTarget getter on the track itself.
The text was updated successfully, but these errors were encountered: