-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically submit as issues detected broken links #7
Comments
this was mostly done in #77 - needs to enable this to happen on a regular basis to close |
In w3c/csswg-drafts#8118 we got an incorrect notification from the bot - the linked spec is live-compiled by ReSpec, so the target anchor does exist after compilation is finished. Strudy should either be able to check the post-compiling version of such specs, or just detect that they're live-compiled and assume that all links into such documents will exist at some point. (Better to have this be wrong and leave a broken link in a spec, than have working links incorrectly flagged as broken with no way to fix the notification.) |
sorry about the false positive - the tool definitely works on top of the ReSpec post-compiled content (so shouldn't have flagged this as an error), and on top of that, we manually review reports before they get submitted. I'll investigate how this came through despite this; but hopefully this should be relatively rare combination of mishaps. |
so, here is what seemed to have happened:
So there is definitely a bug to be fixed in the report updater, and also maybe a lesson that a delay between the manual review and the issue filing is something to be avoided in general. |
The underlying bug (#241) was filed and is now fixed |
Excellent, thanks! |
w3c/reffy#455 allows to identify clearly broken links - these should be submitted as github issues on the relevant repo.
(we discussed whether to try to run this as a regular automatic issue report, but figuring out when a link was previously reported as broken may not be simple - we should at least start by a one-off, and it may be sufficient to run that one-off rarely enough that we can assume the previously raised issue would have been closed)
The text was updated successfully, but these errors were encountered: