Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail browsingContext.navigate if navigation is aborted #799

Open
sadym-chromium opened this issue Oct 22, 2024 · 1 comment
Open

Fail browsingContext.navigate if navigation is aborted #799

sadym-chromium opened this issue Oct 22, 2024 · 1 comment
Labels
module-browsingContext Browsing Context module needs-discussion Issues to be discussed by the working group

Comments

@sadym-chromium
Copy link
Contributor

sadym-chromium commented Oct 22, 2024

Currently, the browsingContext.navigate command's await a navigation succeeds in case of "navigation aborted".

Repro: https://github.com/web-platform-tests/wpt/pull/48751/files
Currently, there is a WPT test test_with_new_navigation_inside_page which is not aligned with the spec.

Spec:

Having that, either WPT test or spec should be changed. We propose the latest: change the spec, so that if the navigation is aborted, the command will fail:

If event received is "navigation failed" or "navigation aborted" return error with error code unknown error.

@sadym-chromium sadym-chromium added the needs-discussion Issues to be discussed by the working group label Oct 22, 2024
sadym-chromium added a commit to GoogleChromeLabs/chromium-bidi that referenced this issue Oct 22, 2024
@OrKoN OrKoN added the module-browsingContext Browsing Context module label Oct 23, 2024
@OrKoN
Copy link
Contributor

OrKoN commented Oct 24, 2024

Related #112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module-browsingContext Browsing Context module needs-discussion Issues to be discussed by the working group
Projects
None yet
Development

No branches or pull requests

2 participants