Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thing-model-* assertions are not being picked up for report generation #436

Open
egekorkan opened this issue Oct 7, 2022 · 4 comments
Open

Comments

@egekorkan
Copy link
Contributor

The assertion in the bullet list of https://w3c.github.io/wot-thing-description/#thing-model-td-generation are not picked up for the report generation. They are part of the playground testing but do not show up in the report. @mmccool you should check why this happens in your tool. In the TD repo, they are not in template.csv but they are in assertions.csv (what I generate)

@egekorkan
Copy link
Contributor Author

The problem is in the td spec. Assertions should not be in a list item without a span since @mmccool tool does not pick them up. I will create PR in the TD spec

@egekorkan
Copy link
Contributor Author

I did a check and these seem to be the only ones:

@mmccool
Copy link
Contributor

mmccool commented Oct 12, 2022

@thjaeckle it seems that the ditto.csv (manual results) do not include manual assertions for the thing-model-* assertions that were missing in the version of the manual.csv that you filled out. Can you please update this ASAP, since otherwise these assertions are at risk?
The current manual.csv is here. Please make a PR to update the Ditto results here. I will merge it as soon as I see it, then close this issue and update the implementation report with the new results. Thanks!

@thjaeckle
Copy link
Contributor

@mmccool ok, done in #447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants