DAOsign milestone 1

[ramilexe]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• This pull request is being made by the same account as the accepted application. The accepted application was made from DaoSign manager personal account. This PR is being made from DaoSign github organization
• I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
• In case of acceptance, an invoice must be submitted and the payment will be transferred to the Polkadot/fiat account provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1770

[PieWol]

Hey @ramilexe thank you for the delivery :)
here you can find my current evaluation. Looking forward to your responses on the issues / questions I raised.
#1140

[PieWol]

Furthermore embedding a struct from one contract into another doesn't create a shared storage instance. Instead, it creates separate instances within each contract's storage. Whats the reason to split the contracts into two?
I'm talking about

pub struct DAOsignApp {
        eip712: DAOsignEIP712,
       .... }

Where DAOsignEIP712 is the storage struct of a separate contract.

[ramilexe]

Hi @PieWol
Thank you for your evaluation, we are reviewing it

[ramilexe]

Hi @PieWol
We have updated the source code of smart contract: PR and also updated the article (link the same)

[PieWol]

thanks @ramilexe ,
I appreciate your changes but could you please provide me an answer on things I mentioned but you didn't change? as in why the contract nesting regarding the storage. Thanks

[PieWol]

Also please start using conditional compilation to avoid having to uncomment any code for testing purposes.

[Burmenska]

@PieWol , hello! just wanted to update you that @ramilexe was away for a few days last week but he is back and will provide you with the updates in the nearest time. thank you for the patience.

[eugeneBskyy]

Hey @PieWol!

We've reviewed your comments with our team and we agreed to make some changes with your suggestions. Currently, our team is working on implementing the requested changes and we anticipate completing them by the end of this week. We will provide more details on what the changes are when they will be completed.

Thank you for your valuable feedback and patience.

[PieWol]

Hey @eugeneBskyy ,
thank you very much for your update on the timeline. I'm happy to hear that you will implement changes. Looking forward to it. 👍

[eugeneBskyy]

Hey @PieWol !

We encountered more challenges than anticipated during the implementation of these changes.

However, I'm pleased to inform you that we've successfully merged the latest updates into the main branch. The changes are now ready for your review. We greatly appreciate your feedback.

Thank you for your patience and understanding.

[PieWol]

Thank you @eugeneBskyy,
I will have my evaluation updated by early next week. I'll let you know.

[eugeneBskyy]

Hey @PieWol !
I just wanted to kindly follow up on the status of the review. Is there anything that is needed from us or do you have any questions that we can help you with?

[PieWol]

I have updated my evaluation. Thanks for the changes.

[github-actions]

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

[github-actions]

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we've created a badge for projects that successfully deliver their first milestone. Please use the badge only in reference to the work that has been completed as part of this grant, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation's guidelines in doing so. If you haven't already, reach out to [email protected] for feedback on your announcement and cross-promotion.

Thank you for your contribution, and good luck! If you have any remaining milestone, let us know if you encounter any delays by leaving a comment on the application PR or submitting an amendment.

[PieWol]

Btw, there is a small typo in your article. In case you'd like to fix that ;)

Profe Storage

[RouvenP]

hi @ramilexe @eugeneBskyy we sent the payment last Friday