Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openbrush-follow-up-2.md #1366

Merged
merged 2 commits into from
Dec 19, 2022
Merged

Update openbrush-follow-up-2.md #1366

merged 2 commits into from
Dec 19, 2022

Conversation

coreggon11
Copy link
Contributor

Project Abstract

This is an update of an already accepted grant.

We want to do some additions, however, I have noticed that after this PR the changes we previously made to the grant application and which were accepted in this PR were discarded, so I am adding these changes as well as one new change regarding ink! 4.0. As we are updating OpenBrush to use ink! 4.0, and the storage was reworked in ink! 4.0, we will need to do many changes in OpenBrush and it may increase the original delivery time and cost, and we want to have it covered in this grant. We also had some team adjustments, they are addressed in this PR.

Grant level

  • Level 1: Up to $10,000, 2 approvals
  • Level 2: Up to $30,000, 3 approvals
  • Level 3: Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

  • The application template has been copied and aptly renamed (project_name.md).
  • I have read the application guidelines.
  • A BTC, Ethereum (USDC/DAI) or Polkadot/Kusama (aUSD/USDT) address for the payment of the milestones is provided in the application.
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The initial PR contains only one commit (squash and force-push if needed).
  • The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).

@CLAassistant
Copy link

CLAassistant commented Dec 14, 2022

CLA assistant check
All committers have signed the CLA.

@Noc2 Noc2 added the amendment This PR proposes changes to an existing application. label Dec 15, 2022
@Noc2 Noc2 self-assigned this Dec 15, 2022
@Noc2 Noc2 added the ready for review The project is ready to be reviewed by the committee members. label Dec 15, 2022
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m very sorry for the issue with the website integration PR. Something like this shouldn’t happen, and it’s a very good thing that we have the version history. But given that your PR changes more than the original PR, we need to review it again. I’m personally happy to go ahead with it. Could you sign the latest version of the CLA?

@coreggon11
Copy link
Contributor Author

Hi @Noc2 and thank you for response. I have signed it.

Noc2
Noc2 previously approved these changes Dec 15, 2022
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'm happy to go ahead with it and share it with the rest of the team.

keeganquigley
keeganquigley previously approved these changes Dec 15, 2022
alxs
alxs previously approved these changes Dec 15, 2022
@alxs
Copy link
Contributor

alxs commented Dec 15, 2022

@coreggon11 note that we no longer pay in USDT on Ethereum. Could you provide a Kusama or Polkadot address if you still want to be paid in USDT? The same goes for the other two amendments. Feel free to have a look at the current list of payment currencies.

@coreggon11 coreggon11 dismissed stale reviews from alxs, keeganquigley, and Noc2 via abfd08f December 15, 2022 16:23
@coreggon11
Copy link
Contributor Author

coreggon11 commented Dec 15, 2022

@alxs thanks for the reply, and sorry for waiting, we needed to discuss this. I see you already approved the changes, but for others, I changed the payment method to DAI (and the same for other mentioned PRs)

@FLebed
Copy link

FLebed commented Dec 19, 2022

Hello guys, a pleasure to meet you. I’m Fedor, Head of Operations at Brushfam. @TtomaS7 resigned from her position in 727 ventures, so the grants she initiated will be transferred to me.

OpenBrush

Typechain

Sol2ink

Toma, please confirm this)

@TtomaS7
Copy link
Contributor

TtomaS7 commented Dec 19, 2022

I confirm it!

@Noc2 Noc2 merged commit 0e014ad into w3f:master Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amendment This PR proposes changes to an existing application. ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants