-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hhvm support #13
base: master
Are you sure you want to change the base?
Add hhvm support #13
Conversation
imsamurai
commented
Mar 16, 2014
- hhvm support
- chnage and simplify travis config
Sorry for the delay. I guess that the code changes has nothing to do with hhvm, and you just added hhvm to travis to prove that the current code works on it. Storing all used keys in another key is a good idea, but there's always the danger that that key get pruned, and we lose all tracks of the used keys. |
Changes Unknown when pulling 4e81480 on imsamurai:master into * on kamisama:master*. |
Changes Unknown when pulling 4e81480 on imsamurai:master into ** on kamisama:master**. |
There's a lot of unrelated changes in this PR. I suggest that you first make a PR with all the code standard fixes, then make another separate PR for the HHMV support. |
Docblock indentation and using tab for indentation should be left as is, as it's the standard used for Cake 2.x. The standard have changed in 3.x, but this plugin is for Cake 2.x, the 3.x version have memcached included by default. |