Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hhvm support #13

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Add hhvm support #13

wants to merge 23 commits into from

Conversation

imsamurai
Copy link

  • hhvm support
  • chnage and simplify travis config

@wa0x6e
Copy link
Owner

wa0x6e commented Aug 4, 2014

Sorry for the delay.

I guess that the code changes has nothing to do with hhvm, and you just added hhvm to travis to prove that the current code works on it.

Storing all used keys in another key is a good idea, but there's always the danger that that key get pruned, and we lose all tracks of the used keys.

@wa0x6e wa0x6e added the fix label Aug 4, 2014
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4e81480 on imsamurai:master into * on kamisama:master*.

@coveralls
Copy link

coveralls commented May 21, 2015

Coverage Status

Changes Unknown when pulling 4e81480 on imsamurai:master into ** on kamisama:master**.

@wa0x6e
Copy link
Owner

wa0x6e commented May 23, 2015

There's a lot of unrelated changes in this PR.

I suggest that you first make a PR with all the code standard fixes, then make another separate PR for the HHMV support.

@wa0x6e
Copy link
Owner

wa0x6e commented May 23, 2015

Docblock indentation and using tab for indentation should be left as is, as it's the standard used for Cake 2.x. The standard have changed in 3.x, but this plugin is for Cake 2.x, the 3.x version have memcached included by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants