Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add to oh-my-zsh #6

Open
ChuckJonas opened this issue Aug 3, 2018 · 8 comments
Open

add to oh-my-zsh #6

ChuckJonas opened this issue Aug 3, 2018 · 8 comments

Comments

@ChuckJonas
Copy link

This is awesome. Not sure what it takes to get it added, but I'd love to see this included in the default OhMyZsh plugin list

https://github.com/robbyrussell/oh-my-zsh/tree/master/plugins

@catalandres
Copy link

Adding it to zsh-users/zsh-completions would make it available in antigen, oh-my-zsh and prezto.

See their contribution guidelines.

@wadewegner ...would you consider adding _sfdx to the project?

@wadewegner
Copy link
Owner

I'm pretty sure I sent PRs to both of these and they were never accepted.

@wadewegner
Copy link
Owner

oh-my-zsh: ohmyzsh/ohmyzsh#6540

zsh-completions: zsh-users/zsh-completions#550

If you have thoughts on how to get them to accept, I'd be happy to update and send along.

@tekamoment
Copy link

@wadewegner Hi! Just checked on the status of these.zsh-completions has accepted your pull request. oh-my-zsh has two comments before accepting your pull request.

@rsoesemann
Copy link

@wadewegner did you ever get this finished?

@nchursin
Copy link

nchursin commented Aug 3, 2019

It was merged, but it actually doesn't seem working. I tried adding the plugin to my .zshrc, but no completions appeared

@daeschwed
Copy link

@nchursin try resetting completions, that did the trick for me:

rm ~/.zcompdump*
compinit

@unixorn
Copy link

unixorn commented Nov 17, 2019

I'm adding this repo to the awesome-zsh-plugins in unixorn/awesome-zsh-plugins#828.

As far as I can tell, upstream oh-my-zsh isn't taking new plugins or themes for the main repo. Standalone git repositories like this make it much easier for people using other frameworks though, so overall that feels like a win.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants