Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨feat: add video component #30

Merged
merged 2 commits into from
Aug 11, 2024
Merged

✨feat: add video component #30

merged 2 commits into from
Aug 11, 2024

Conversation

East-cloud-of-forest
Copy link
Contributor

Video componenet 는 object 로 나뉘지 않고 모두 props 로 처리했습니다.

Video Component Props

  • size : large | medium | small
  • favorite : hover 시 표시되는 별의 on off 를 설정합니다
  • onClick : video component 전체 클릭을
  • favoriteOnclick : favorite 클릭을 제어 합니다
  • member : single | multi
  • memberMultiCount : member 가 multi 일시 숫자를 전해주면 member 부분에 표시할 수 있습니다
  • memberSingleChip : member 가 single 일시 element 를 전하면 member 부분에 표시 됩니다 chips 를 전달할 수 있습니다
  • src : 비디오 썸네일
  • alt : 썸네일의 alt
  • data : 하단의 날짜
  • view : 하단의 조회수

❗favorite 에 쓰이는 회색 별 svg 는 이미 있는 svg 를 사용했는데 아무곳에서도 사용되는 곳이 없어서 size 및 color 를 변경했습니다.
❗figma 의 사이즈를 최대한 맞췄는데 글자 간격이 묘하게 좀 먼 느낌.. 입니다.

@kms0219kms kms0219kms self-requested a review August 11, 2024 07:11
Copy link
Member

@kms0219kms kms0219kms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kms0219kms kms0219kms merged commit 0db5092 into main Aug 11, 2024
2 checks passed
@kms0219kms kms0219kms deleted the feature/video branch August 13, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants