Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

\gamma_{yzz} appears twice #522

Closed
jin-saltandpepper opened this issue Nov 14, 2024 · 2 comments · Fixed by #523
Closed

\gamma_{yzz} appears twice #522

jin-saltandpepper opened this issue Nov 14, 2024 · 2 comments · Fixed by #523

Comments

@jin-saltandpepper
Copy link
Contributor

Dear Developers

On page 136 of the user guide, \gamma_{yzz} appears twice, as it also does on line 996 of gyrotropic.F90. Could it be that the second occurrence of "yzz" is meant to be "xyx"? Please let me know if this interpretation is correct.

Best regards

@stepan-tsirkin
Copy link
Collaborator

You are right, this is a typo.

In the corresponding column the variable y is written, which is equal to arr33N(3, 1, :) . The 3 here is zwhich by Levi-Chevita is converted to xy, so the component is called xyx

xx = arr33N(1, 1, :)
yy = arr33N(2, 2, :)
zz = arr33N(3, 3, :)
xy = arr33N(1, 2, :)
xz = arr33N(1, 3, :)
yz = arr33N(2, 3, :)
x = arr33N(3, 2, :)
y = arr33N(3, 1, :)
z = arr33N(2, 1, :)

You are right, you are welcome to make a small PR to fix that.

@jin-saltandpepper
Copy link
Contributor Author

Thank you very much for your prompt response. I have submitted a PR to fix that.

@qiaojunfeng qiaojunfeng linked a pull request Nov 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants