feat: derive Clone for KeyPair and XKey #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protochron
force-pushed
the
nkeys_clone
branch
from
9909938 to
84c5a75
Compare
Allow KeyPair and XKey structs to be cloned. We have no technical reason not to do this, since it is trivial to copy out a private key from either key type and the underlying members of the struct are all already Clone. Signed-off-by: Dan Norris <[email protected]>
protochron
force-pushed
the
nkeys_clone
branch
from
84c5a75 to
3e49a56
Compare
brooksmtownsend
approved these changes
Sep 19, 2024
|
I've been working around this by using an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
Allow KeyPair and XKey structs to be cloned. We have no technical reason not to do this, since it is trivial to copy out a private key from either key type and the underlying members of the struct are all already Clone.
Related Issues
Release Information
next
Consumer Impact
Testing
Unit Test(s)
Acceptance or Integration
Manual Verification