Migrate watertap.ui.fsapi to idaes_flowsheet_processor #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbianchi-lbl
added a commit
to lbianchi-lbl/idaes-flowsheet-processor
that referenced
this pull request
Nov 21, 2024
lbianchi-lbl
added a commit
to watertap-org/idaes-flowsheet-processor
that referenced
this pull request
Nov 26, 2024
#6) * Add initial implementation of pytest plugin * Add README with usage examples and basic tests * Add previously missing import * Temporarily set watertap requirement to use watertap-org/watertap#1518 * Add missing __init__.py file * Handle typing limitations on Python 3.9 * Ensure Git history is available to calculate version correctly * Avoid replacing collection of ordinary Python tests * Add nodeid to improve display when running in non-verbose mode * Ensure entry points are unique
lbianchi-lbl
requested review from
dangunter,
adam-a-a,
MichaelPesce,
MarcusHolly and
luohezhiming
MarcusHolly
approved these changes
Nov 26, 2024
MichaelPesce
approved these changes
Nov 26, 2024
This is an excellent point @MarcusHolly. I've added a section to the documentation (commit 666e935) to explain how to run tests for the flowsheet interfaces. Feel free to take a look and let me know if you have any feedback or suggestions. |
lbianchi-lbl
added a commit
to watertap-org/idaes-flowsheet-processor
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve: #1517
Changes proposed in this PR:
watertap/uiwatertap.ui.fsapi -> idaes_flowsheet_processor.api(we might want to just use the top-level package instead; see watertap-org/idaes-flowsheet-processor#FIXME)idaes-flowsheet-processor(currently from the repo URL https://github.com/watertap-org/idaes-flowsheet-processor) as an optional dependency under thetestingtargetdevtarget and splitting its contents between thetestingtarget andrequirements-dev.txtBefore merging
idaes-flowsheet-processorrequirement currently pointing to Add pytest plugin for project-agnostic testing of flowsheet interfaces idaes-flowsheet-processor#6Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: