Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timer.unref throws ignorable exceptions in the UI thread #32

Open
pvh opened this issue Jun 19, 2017 · 0 comments
Open

Timer.unref throws ignorable exceptions in the UI thread #32

pvh opened this issue Jun 19, 2017 · 0 comments

Comments

@pvh
Copy link

pvh commented Jun 19, 2017

The bonjour implementation appears to works totally fine from the UI thread in my electron app except it throws exceptions due to the browser implementation of timers not having an unref method.

Adding a simple test if unref is defined to the two lines where it's called resolves this.

Would you take this patch?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pvh