Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update errors on Today tab for no current conditions and no forecast #2094

Open
3 tasks
partly-igor opened this issue Nov 19, 2024 · 1 comment
Open
3 tasks
Labels
Bug Something isn't working Eng
Milestone

Comments

@partly-igor
Copy link
Collaborator

Description

In #2003 @jamestranovich-noaa noted that with the updated designs the error state when both the current conditions and the forecast failed to load looked off. For this case we should:

  1. Hide the Current conditions and Today headings
  2. Show one error that spans the width of the container

Update design:

Figma documentation

Design / context

Acceptance Criteria

  • Only one error shows when both the current conditions and the forecast error out
  • The headings or those sections are hidden
  • Implementation follows above designs.

Tag the related milestone to this story

@colinmurphy01
Copy link
Collaborator

This will be a good ticket to address during the holidays.

@shadkeene @coreypieper @mel-keene-gsa if you feel this should be done sooner please weigh in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Eng
Projects
Status: Now - Expand - V3
Development

No branches or pull requests

2 participants