Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-built tests failing on PRs #31231

Closed
foolip opened this issue Oct 14, 2021 · 2 comments · Fixed by #31239
Closed

update-built tests failing on PRs #31231

foolip opened this issue Oct 14, 2021 · 2 comments · Fixed by #31239

Comments

@foolip
Copy link
Member

foolip commented Oct 14, 2021

Two examples:
#31223
#31230

From one of the logs:

+ .virtualenv/bin/python gentest.py
Traceback (most recent call last):
  File "gentest.py", line 3, in <module>
    genTestUtils('../element', '../element', 'templates.yaml', 'name2dir.yaml', False)
  File "/home/test/web-platform-tests/html/canvas/tools/gentestutils.py", line 123, in genTestUtils
    templates = yaml.load(open(TEMPLATEFILE, "r").read())
TypeError: load() missing 1 required positional argument: 'Loader'

This is probably a regression that landed in master. I'm filing this now without further investigation and don't have time to look closer right now.

cc @web-platform-tests/wpt-core-team

@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 14, 2021

Probably this bug in yesterday's release: yaml/pyyaml#576

https://github.com/web-platform-tests/wpt/blob/7b0ebaccc62b566a1965396e5be7bb2bc06f841f/html/canvas/tools/build.sh doesn't pin the version

@Ms2ger
Copy link
Contributor

Ms2ger commented Oct 14, 2021

(We might wanna switch to safe_load anyway, even though input is trusted.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants