Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mark attrs as tentative since they were added mid-year to interop-tracked files #48797

Merged
merged 4 commits into from
Oct 29, 2024
Merged

mark attrs as tentative since they were added mid-year to interop-tracked files #48797

merged 4 commits into from
Oct 29, 2024

Conversation

cookiecrook
Copy link
Contributor

@cookiecrook cookiecrook assigned cookiecrook and unassigned kojiishi Oct 24, 2024
@cookiecrook cookiecrook marked this pull request as draft October 24, 2024 04:34
@cookiecrook cookiecrook changed the title move colindextext/rowindextext to tentative move colindextext/rowindextext/description to tentative since these are interop-tracked files and these were added mid-year Oct 24, 2024
annevk
annevk reviewed Oct 24, 2024
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but it seems like we also need something for the IDL-based test, no?

@cookiecrook
Copy link
Contributor Author

This looks good, but it seems like we also need something for the IDL-based test, no?

That was also added mid-year to the metadata. I rolled it back out with:

@cookiecrook cookiecrook changed the title move colindextext/rowindextext/description to tentative since these are interop-tracked files and these were added mid-year mark attrs as tentative since they were added mid-year to interop-tracked files Oct 25, 2024
@cookiecrook cookiecrook marked this pull request as ready for review October 25, 2024 23:39
@cookiecrook cookiecrook merged commit 69d6994 into web-platform-tests:master Oct 29, 2024
20 checks passed
@cookiecrook cookiecrook deleted the tentative-colindextext-rowindextext branch October 29, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk left review comments

@twilco twilco twilco approved these changes

@nolanlawson nolanlawson Awaiting requested review from nolanlawson

@TakayoshiKochi TakayoshiKochi Awaiting requested review from TakayoshiKochi

Assignees

@cookiecrook cookiecrook

Labels
custom-elements html wg-webplatform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pulling tests that were added mid-year to Interop-tracked files (and have incomplete API support)
5 participants
@cookiecrook @annevk @twilco @kojiishi @wpt-pr-bot