Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Footer links #247

Closed
adrianvrj opened this issue Nov 21, 2024 · 25 comments · Fixed by #271
Closed

[fix] Footer links #247

adrianvrj opened this issue Nov 21, 2024 · 25 comments · Fixed by #271
Assignees
Labels

Comments

@adrianvrj
Copy link
Member

This issue will be part of ODHack10, please apply via Onlydust app

  • Fix the footer links in order to send the user to a blank page instead of opening the links on the same tab.
  • Please read contributors guide before asking for an issue.
@NueloSE
Copy link
Contributor

NueloSE commented Nov 21, 2024

@adrianvrj
Hi, I'm nuelo and I'll be working on issue #247.

I estimate this will take 12hr to complete.

This is how I would tackle this issue:

  • i will implement the changes in : footer.tsx
  • i will set all the <a> with the target attribute and value of _blank

kindly assign.

@MariangelaNM
Copy link
Contributor

Hi, I'm Mariángela, and I'll be working on issue #247.

Here's my approach to tackle this issue:

  • Add target="_blank" to the relevant links.

  • Update dynamically rendered links to ensure proper behavior.

  • Test thoroughly to verify functionality and usability improvements.

@BrunoAmbricca
Copy link
Contributor

I would like to work on this issue

@abdegenius
Copy link

I'd love to work on this!

@wheval
Copy link
Contributor

wheval commented Nov 21, 2024

Hello @adrianvrj, I'm Wheval a frontend developer with multiple experiences working with Nextjs and TypeScript. Can i work on this?

I would ensure the user opens a blank page when they click. This can be easily done with a _blank target attribute.
I would also test it on my devices.

ETA is 5 hours.

@Kingsuite
Copy link

I'd like to handle this task.

@OWK50GA
Copy link

OWK50GA commented Nov 21, 2024

Hi, I'm Wilfrid, a Frontend Web Developer and I'll be working on issue #247

I estimate this will take 3 hours to complete.

This is how I would tackle this issue:
I will trace where the links are gotten in the footer component, and update their hrefs to send the user to a blank page

@lauchaves
Copy link
Contributor

Hi, I'm Lau Chaves and I'll be working on issue #247

I estimate this will take less than 10h to complete.

This is how I would tackle this issue:
I update the tags in the footer component to include the target="_blank" and rel="noopener noreferrer" attributes.

I have over 5 years of experience working with JavaScript, React, and TypeScript, ruby... Im also part of Dojo Coding Costa Rica!

@Benjtalkshow
Copy link
Contributor

Could I take a shot at this?

@GideonBature
Copy link

May I take this issue on?

My name is Gideon Bature, a Software Engineer with experience using TypeScript. If assigned, I should be able to send my first PR within 48 hrs.

Thank you!

@Bran18
Copy link

Bran18 commented Nov 21, 2024

Hello there. I’m Brandon, part of the ⛩️ Dojo Coding community, and I would love to contribute to this project! 🚀 This might be my first contribution here.

I've done quite a few of these ones in our DEFI/Web3 apps, I'm part of the Bitcash/Bitlauncher team https://bitlauncher.ai/en (this is a really similar app to the one you have). And I would love to help out with the fix of the links.

Lmk if I can start working on it. Here’s my GitHub profile: GitHub: https://github.com/Bran18 and my OnlyDust profile: https://app.onlydust.com/u/Bran18.

BTW tks for taking the time 🙏

@Villarley
Copy link
Contributor

Villarley commented Nov 21, 2024

Hi, I’m Santiago Villarreal Arley, a proactive and communicative developer with experience in both front-end and back-end Web3 development. I’m a proud member of Dojo Coding and have worked on various projects built on StarkNet and Stellar, where I actively contributed to creating scalable and efficient solutions. I also won a Web3 hackathon Buildathon for my work on BuildMyEvent, an open-source blockchain project focused on solving real-world challenges and integrating useful features.

I’ll be working on issue #247.

I estimate this will take 12 hours to complete.

This is how I would tackle this issue:

Update the footer links to ensure they open in a new tab (target="_blank") instead of the same one.
Test the functionality to confirm all links behave as expected across different pages.
Review and ensure the changes align with the contributors’ guide and project standards.
For this task, I’ll fix the footer links to ensure they open in a new tab instead of the same one, enhancing the user experience. I’ll carefully follow the contributors’ guide and project guidelines to deliver a clean and effective solution.

Pls feel free to reach out!!!

@ShantelPeters
Copy link
Contributor

I’m interested in this one.

@Michaelkingsdev
Copy link

Can I be assigned to this? I am an experienced frontend developer with 3 years of experience.

@bydan0
Copy link
Contributor

bydan0 commented Nov 21, 2024

I’d like to resolve this. I will add a "target _blank" to open in new tab the links properly because they are external links :)

@Kaminar-i
Copy link

Can I be given this task to handle ?

@Jimmy-csc
Copy link

Hi, I’m interested in this issue.

@kimcascante
Copy link
Contributor

Hi, I'm Kimberly Cascante a Dojo Coding member :) and I'll be working on issue #247

I estimate this will take around 48 to 72 hours to complete.

This is how I would tackle this issue:

I will try to understand the code project, identify where the links are updating the page, update the links and test the solution and finally share if it is correct.

Looking for my first contribution.

@MullerTheScientist
Copy link

I am a full-stack developer with experience in QA testing and languages like Python, Cairo, Solidity, React, and JavaScript. please i'd love to jump on this task

@mariocodecr
Copy link
Contributor

Hii! My name is Mario Araya, I’m a Software Developer with 2+ years of experience. I have worked with backend technologies such as Cairo, Java, and C#, as well as frontend development using React, NextJS, and JavaScript/TypeScript. I’ve made contributions to open-source projects, completed a Starknet Bootcamp, exercises on NodeGuardians, finished Starklings, and participated in multiple hackathons. I’m also a member of the Dojo Coding community here in Costa Rica.

I will modify the footer links to ensure they open in a new tab instead of the same tab. This can be achieved by adding the target="_blank" attribute to the anchor () tags in the footer. Additionally, I will ensure that the rel="noopener noreferrer" attribute is included for security reasons, to prevent any potential vulnerabilities from opening the link in a new tab.

@ryzen-xp
Copy link

Could I take over this issue?

@Amarjeet325
Copy link

I’d like to help with this.

@Supa-mega
Copy link

Could I try solving this?

@vestor-dev
Copy link

hey sir I'd like to handle this task.
i'm a frontend developer with experience
i would really love to contribute to your project
kindly assign :)

@akintola4
Copy link

Can I take care of this issue?i would love to build it , this is my twitter account for my works https://x.com/photofola , i would be happy if i am give this task for my first ever task on this platform

@EmmanuelAR EmmanuelAR linked a pull request Nov 26, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.