New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.attachStream should accept DOMElement and css selector #9

Open

jeromeetienne opened this issue Sep 23, 2012 · 1 comment

jeromeetienne commented Sep 23, 2012

relying on id is a useless limit
id are global to the page and may cause conflict
document.querySelector() is present in all browser supporting webrtc
- so css selector are easy to add without changing dependancies

Member

dennismartensson commented Sep 23, 2012

This do look like a good fix. Can you please submit a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment