Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Broken on webOS 1 and 2 #160

Open
throwaway96 opened this issue Apr 10, 2024 · 17 comments
Open

Bug: Broken on webOS 1 and 2 #160

throwaway96 opened this issue Apr 10, 2024 · 17 comments
Labels
bug Something isn't working question Further information is requested

Comments

@throwaway96
Copy link
Member

throwaway96 commented Apr 10, 2024

Apparently 0.3.4-rc1 doesn't work on webOS 1 and 2. I wasn't even aware that it worked on those versions, since they use WebKit for WAM.

I'm not actually sure which webOS versions each YTAF release is broken on. As I have said elsewhere, it's difficult/impossible for me to properly test on webOS <4, so I have to rely on reports from users. I think 0.3.3 may work on webOS 1/2, but I'd like someone to confirm that. 0.3.3 does not work on webOS 1/2 either.

The problem is that the userscript is not running at all (due to a syntax error in the case of 0.3.3 on webOS 3.x). Users often can't tell the difference between YTAF running but failing to block some ads and the YTAF userscript not running at all. Generally, if the green button doesn't bring up the options panel, the userscript isn't running. I'm thinking about adding something to make it more obvious. Maybe another userscript with very simple JS that will display an error if the main YTAF userscript doesn't run.

@throwaway96 throwaway96 added bug Something isn't working question Further information is requested labels Apr 10, 2024
@fire332
Copy link

fire332 commented Apr 11, 2024

Have you tried adding the appropriate browsers to .browserslistrc?

@throwaway96
Copy link
Member Author

It doesn't seem like browserslist supports WebKit—at least not directly. Maybe ios_saf or something?

@fire332
Copy link

fire332 commented Apr 11, 2024

Honestly, those browsers are so old that it's worth having a separate build for them to not unload a truck load of redundant polyfills for newer webOS versions.

@mrmuiz
Copy link

mrmuiz commented Apr 11, 2024

0.3.3 does not work on WebOS 1.0, no green button etc. 0.3.2 is the last working version.

@throwaway96
Copy link
Member Author

This should run on webOS 1 and 2 and block most of the new ads: https://github.com/throwaway96/youtube-webos/releases/tag/v0.3.2-webkit1

@mrmuiz
Copy link

mrmuiz commented Apr 12, 2024

This should run on webOS 1 and 2 and block most of the new ads: https://github.com/throwaway96/youtube-webos/releases/tag/v0.3.2-webkit1

Works like a charm !! Very cool. THX !! Tested on WebOS 1

@throwaway96
Copy link
Member Author

People with webOS 1 or 2: please try https://github.com/throwaway96/youtube-webos/releases/tag/v0.3.5-dev2.

@mrmuiz
Copy link

mrmuiz commented May 27, 2024 via email

@h3ndrik
Copy link

h3ndrik commented May 28, 2024

Hmm, I get pre-roll ads on version 0.3.2 (WebOS 1.4)

@mrmuiz
Copy link

mrmuiz commented May 28, 2024

Hmm, I get pre-roll ads on version 0.3.2 (WebOS 1.4)

afbeelding
Works fine on this version.

@f-lirtik
Copy link

I have webos 2, this is not work Dev Build v0.3.5-dev2, but v0.3.2-webkit1 work very good. thanks.

@Egorkat
Copy link

Egorkat commented Jun 24, 2024

I have webos 2, this is not work Dev Build v0.3.5-dev2, but v0.3.2-webkit1 work very good. thanks.

How can install this apk to webOS 1 device, please?
If I try to install it via HomeBrew Dev Manager, I get an error:
Unable to exec: luna-send-pub: Failed to call getIDs

@throwaway96
Copy link
Member Author

@Egorkat

What version of Dev Manager are you using? If not the latest one, then try that.

@Egorkat
Copy link

Egorkat commented Jun 26, 2024

It is latest 1.13.3

@h3ndrik
Copy link

h3ndrik commented Jul 14, 2024

Note: The correct workaround as of now is v0.3.2-webkit1 as throwaway96 said. That works for me on webOS 1.4. Has Sponsorblock working and removes the pre-roll ads.

Just don't make the same mistake I made and install the regular 0.3.2 version. That shows all the pre-roll ads, just Sponsorblock works. Later versions up to 0.3.4 don't work properly on webOS 1.

And a note to myself: Install downloaded IPKs via the Install button at the top of webos-dev-manager. If it fails, uninstall the app first. All the config will stay on the device. If you get some getID error, restarting the TV after the uninstall and reconnecting should make it work.

@kotucocuk
Copy link

Note: The correct workaround as of now is v0.3.2-webkit1 as throwaway96 said. That works for me on webOS 1.4. Has Sponsorblock working and removes the pre-roll ads.

Just don't make the same mistake I made and install the regular 0.3.2 version. That shows all the pre-roll ads, just Sponsorblock works. Later versions up to 0.3.4 don't work properly on webOS 1.

And a note to myself: Install downloaded IPKs via the Install button at the top of webos-dev-manager. If it fails, uninstall the app first. All the config will stay on the device. If you get some getID error, restarting the TV after the uninstall and reconnecting should make it work.

same too me

Device: 32LS650V
Firmware :04.06.75
Webos Version: 2.2.0

@truealex81
Copy link

Just confirm that v0.3.2-webkit1 is working on my 42LB673V (WebOS 1.4.0-2536). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

8 participants