Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SponsorBlock segments not rendered on videos with chapters #8

Open
Informatic opened this issue Dec 24, 2021 · 3 comments · May be fixed by #9
Open

SponsorBlock segments not rendered on videos with chapters #8

Informatic opened this issue Dec 24, 2021 · 3 comments · May be fixed by #9

Comments

@Informatic
Copy link
Member

Seems like chapters have just been rolled out to YouTube TV. This causes our SponsorBlock segments rendering to break.

Skips are properly executed.

Test video: https://www.youtube.com/watch?v=R3iNAQqqnjE
Screen capture

@Informatic
Copy link
Member Author

New slider class: .ytlr-multi-markers-player-bar-renderer
slider

@Informatic
Copy link
Member Author

Another issue: original slider is replaced with segmented one fairly randomly - we now also need to watch for slider removal in parent node. Whoops.

@Informatic Informatic linked a pull request Dec 24, 2021 that will close this issue
@LuminescentMoon
Copy link

Just an update on this: I've made a quick preact component a while back that emulates the rect and opacity/visibility of a unmanaged element in a managed element which would allow having the sponsorblock overlay "in" the slider while being out of YT's VDOM. The only reason I haven't made a pull request with it is because I had trouble emulating the proper stacking context which means the sponsorblock overlay would not be behind certain elements as it should be, causing minor visual bugs.

Just ping me if you want the code for it as I'm busy with other stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants