From 8ee46dea69224f1800bb1cab7863e06e60e082f9 Mon Sep 17 00:00:00 2001 From: Edsko de Vries Date: Fri, 25 Oct 2024 10:36:51 +0200 Subject: [PATCH] Obsolete TODOs --- grapesy/src/Network/GRPC/Client/Session.hs | 2 -- grapesy/src/Network/GRPC/Util/Session/Channel.hs | 3 --- 2 files changed, 5 deletions(-) diff --git a/grapesy/src/Network/GRPC/Client/Session.hs b/grapesy/src/Network/GRPC/Client/Session.hs index 190803ae..f55a3974 100644 --- a/grapesy/src/Network/GRPC/Client/Session.hs +++ b/grapesy/src/Network/GRPC/Client/Session.hs @@ -109,8 +109,6 @@ instance SupportsClientRpc rpc => InitiateSession (ClientSession rpc) where case verifyAllIf connVerifyHeaders responseHeaders of Left err -> throwIO $ CallSetupInvalidResponseHeaders err Right hdrs -> do - -- TODO: - -- If we omit this call to 'updateConnectionMeta', no tests fail. Connection.updateConnectionMeta conn responseHeaders cIn <- getCompression $ requiredResponseCompression hdrs return $ FlowStartRegular $ InboundHeaders { diff --git a/grapesy/src/Network/GRPC/Util/Session/Channel.hs b/grapesy/src/Network/GRPC/Util/Session/Channel.hs index c8a70812..5b02206c 100644 --- a/grapesy/src/Network/GRPC/Util/Session/Channel.hs +++ b/grapesy/src/Network/GRPC/Util/Session/Channel.hs @@ -141,9 +141,6 @@ data RegularFlowState flow = RegularFlowState { -- This TMVar is written to for incoming messages ('recvMessageLoop') and -- read from for outgoing messages ('sendMessageLoop'). It acts as a -- one-place buffer, providing backpressure in both directions. - -- - -- TODO: . - -- It might make sense to generalize this to an @N@-place buffer. , flowMsg :: TMVar (StreamElem (Trailers flow) (Message flow)) -- | Trailers