Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable HTTP-level timeouts altogether #123

Closed
edsko opened this issue Apr 4, 2024 · 3 comments · Fixed by #265
Closed

Disable HTTP-level timeouts altogether #123

edsko opened this issue Apr 4, 2024 · 3 comments · Fixed by #265
Labels
enhancement New feature or request priority: low Minor enhancements

Comments

@edsko
Copy link
Collaborator

edsko commented Apr 4, 2024

Currently we have a workaround in place, but it only works on 64-bit systems. See kazu-yamamoto/http2#112 and kazu-yamamoto/http2-tls#12 .

@edsko edsko added enhancement New feature or request priority: medium Should be done before the library can be considered complete labels Apr 4, 2024
@edsko
Copy link
Collaborator Author

edsko commented Apr 4, 2024

Marked this as "enhancement" rather than bug because on 64-bit machines this works just fine, and on 32-bit machines things will still work, except that if we have more than 30 minutes between RPC messages, the connection will be broken. Could be argued that this constitutes a bug, however.

@edsko
Copy link
Collaborator Author

edsko commented Apr 6, 2024

One annoying thing is that in the interop tests, when a test fails we might see

Uncaught exception: Thread killed by timeout manager

This can happen if a server is terminated before our worker gets a chance to install its own exception handler. (See #124 for a detailed analysis of these TimeoutThread exceptions.)

@edsko edsko added priority: low Minor enhancements and removed priority: medium Should be done before the library can be considered complete labels Jul 3, 2024
@edsko
Copy link
Collaborator Author

edsko commented Jul 3, 2024

Marked as low priority since we don't care about 32-bit machines (for now).

edsko added a commit that referenced this issue Dec 17, 2024
edsko added a commit that referenced this issue Dec 17, 2024
edsko added a commit that referenced this issue Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: low Minor enhancements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant