We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AFAIK now open-uri uses simple paths /some/path/image.jpg for local files.
open-uri
/some/path/image.jpg
And that's why this check prohibits the upload of local images https://github.com/werein/prestashop/blob/master/lib/prestashop/mapper/models/image.rb#L32
The text was updated successfully, but these errors were encountered:
Yes, we are uploading only remote files, but that shouldn't be problem to add this functionality
Sorry, something went wrong.
Should we just get rid of the URI check and pass it directly?
I'd suggest to make the check more sophisticated otherwise it may fail, when the path doesn't exists.
You want to check if it's a path or a URL - and if it's a path check for existence?
I would have delegated this further down the to the underlying (MiniMagick) implementation. That should give an error we can just catch.
No branches or pull requests
AFAIK now
open-uri
uses simple paths/some/path/image.jpg
for local files.And that's why this check prohibits the upload of local images https://github.com/werein/prestashop/blob/master/lib/prestashop/mapper/models/image.rb#L32
The text was updated successfully, but these errors were encountered: