Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support express@5 router #59

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Conversation

wesleytodd
Copy link
Owner

Fixes #57, although I did not see the same error as reported. This does get the tests passing in with express@5 though.

Copy link

socket-security bot commented Feb 27, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] environment, filesystem, network Transitive: eval +48 1.71 MB dougwilson

View full report↗︎

@wesleytodd wesleytodd mentioned this pull request Feb 27, 2024
Copy link
Collaborator

@Megapixel99 Megapixel99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check for node 14 seems to be stuck on npm it (unsure if express 5 supports node 14), the code looks good though.

@wesleytodd
Copy link
Owner Author

I have had a few of my actions recently get stuck like this. I will wait a bit then give it a kick and see if a retry works. AFAIK these all should be supported. Express 5 supports back to node 4 I think, maybe technically even the code works as far back as 0.10.

@wesleytodd
Copy link
Owner Author

Ah, it is not express or node support, it is the npm which shipped with node 14 which does not support the aliases. I think that was npm 6. I will try it again with a newer npm.

@wesleytodd
Copy link
Owner Author

Ok, I decided to just drop node 14 since this is targeting the 1.x we can take the technically breaking change of note testing in node@14 but the code should still run despite the tests not passing.

@wesleytodd
Copy link
Owner Author

Ok well since we got the test passing and I have an approval I will just go ahead and merge now. I will still leave that PR open until the morning.

@wesleytodd wesleytodd merged commit 77728bb into release/v1.0.0 Feb 27, 2024
5 checks passed
@wesleytodd wesleytodd deleted the express-5-support branch February 27, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants