Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to save attachments using a FileField #126

Open
joshuadavidthomas opened this issue Nov 13, 2023 · 2 comments
Open

Add ability to save attachments using a FileField #126

joshuadavidthomas opened this issue Nov 13, 2023 · 2 comments
Labels
🏋️ improvement Enhancements or optimizations to existing functionality

Comments

@joshuadavidthomas
Copy link
Member

https://github.com/treyhunner/django-email-log/blob/461f2ced7bd447ac2c22868fa331520d7dc3798a/email_log/models.py#L43
@joshuadavidthomas joshuadavidthomas changed the title Should attachments be a separate model with a file field instead of being saved directly in the database? Add ability to save attachments using a FileField May 2, 2024
@joshuadavidthomas
Copy link
Member Author

Yes, I think this would be a good improvement. Keep the default of saving the attachments in the database as it currently is, but add the option to store it in a FileField in a separate model to leverage different storage.

@joshuadavidthomas joshuadavidthomas added 🏋️ improvement Enhancements or optimizations to existing functionality and removed enhancement labels May 2, 2024
@joshuadavidthomas
Copy link
Member Author

My initial thought on a seamless way to do this is look if settings.STORAGES["email_relay"] is set. If it is, use an Attachment model with a file field with that storage backend. Otherwise, use the database as it currently works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🏋️ improvement Enhancements or optimizations to existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joshuadavidthomas