Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple WYSIWYG editor for exercise descriptions #189

Open
rolandgeider opened this issue Jun 20, 2022 · 10 comments · May be fixed by #283
Open

Add simple WYSIWYG editor for exercise descriptions #189

rolandgeider opened this issue Jun 20, 2022 · 10 comments · May be fixed by #283
Assignees
Labels
good first issue Good for newcomers

Comments

@rolandgeider
Copy link
Member

rolandgeider commented Jun 20, 2022

Exercise descriptions are currently HTML, so the user should be able to edit it as well. This HTML is cleaned server side when saving, only the following tags are allowed: 'b', 'i', 'strong', 'em', 'ul', 'ol', 'li', 'p'

@sandimilohanic
Copy link
Contributor

Hi, I would like to try resolve this issue, could you assign me?

@rolandgeider
Copy link
Member Author

It's yours :)

This is also in the exercise crowdsourcing branch, like the other issue with the translations

@rolandgeider
Copy link
Member Author

BTW, you can reach the form from the workout tab -> top right menu -> contribute exercise in the description step

@rolandgeider
Copy link
Member Author

This was also merged into master in the meantime btw

@sandimilohanic
Copy link
Contributor

@rolandgeider can I use this package https://pub.dev/packages/markdown_editable_textinput as a WYSIWYG editor and configure it ?

@rolandgeider
Copy link
Member Author

Sadly we need HTML for the description. We've been thinking of also allowing to store markdown in the description, but this would need some changes in the backend as well

@sandimilohanic
Copy link
Contributor

Sadly we need HTML for the description. We've been thinking of also allowing to store markdown in the description, but this would need some changes in the backend as well

Sorry, I sent you wrong package, I mean this one https://pub.dev/packages/html_editor_enhanced

@rolandgeider
Copy link
Member Author

ah, yes, better 😄

Sure, go ahead

sandimilohanic pushed a commit to sandimilohanic-bussiness/wger-flutter that referenced this issue Oct 29, 2022
sandimilohanic pushed a commit to sandimilohanic-bussiness/wger-flutter that referenced this issue Oct 29, 2022
@rolandgeider rolandgeider linked a pull request Feb 7, 2023 that will close this issue
3 tasks
@rolandgeider
Copy link
Member Author

hi @Radiant690 , thanks for asking, but there is already a PR for this (just linked it so it's more obvious)

@rolandgeider
Copy link
Member Author

I just saw that the description field is currently disabled, do you want to take a look @Radiant690 ? I've pulled the branch and solved the current merge conflicts to feature/wysiwyg-description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants